This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC, gdbserver] Avoid defining linux_read_offsets when the target does not need it
- From: Yao Qi <yao at codesourcery dot com>
- To: <lgustavo at codesourcery dot com>
- Cc: "'gdb-patches at sourceware dot org'" <gdb-patches at sourceware dot org>, Mike Frysinger <vapier at gentoo dot org>
- Date: Wed, 15 May 2013 22:17:50 +0800
- Subject: Re: [RFC, gdbserver] Avoid defining linux_read_offsets when the target does not need it
- References: <519370AE dot 50908 at codesourcery dot com>
Luis,
I went through the patch, and didn't see something wrong. Some nits on
changelog.
On 05/15/2013 07:25 PM, Luis Machado wrote:
2013-05-15 Luis Machado<lgustavo@codesourcery.com>
* linux-low.c: Move definition checks upwards for PT_TEXT_ADDR,
PT_DATA_ADDR and PT_TEXT_END_ADDR. Update comments.
^^ Two spaces after ".".
(linux_read_offsets): Remove PT_TEXT_ADDR, PT_DATA_ADDR and
PT_TEXT_END_ADDR guards. Update comments.
^ Likewise.
(linux_target_op) <read_offsets): Conditionally define to
^ ")" -> ">"
linux_read_offsets if the target is UCLIBC and if it defines
PT_TEXT_ADDR, PT_DATA_ADDR and PT_TEXT_END_ADDR.
--
Yao (éå)