This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH ARM] Fixing problem of 32bit multiplication instruction 'smull'


On Tuesday 14 May 2013 09:15:53 Jayant R. Sonar wrote:
> Consider the following sample assembly code.

could you make that into a test case ? :)

       && nRs   != 15
>        && nRm   != 15
>        && nRdHi != nRdLo
> -      && nRdHi != nRm
> -      && nRdLo != nRm)
> +      && (state->is_v6
> +          || (   nRdHi != nRm
> +              && nRdLo != nRm)))

style is incorrect ;)

> It alters the condition check for targets ARMv6 and above only.
> Can someone please review this change?

i'm not sure how many ARM ISA experts watch over the sim anymore

what i tend to do is write a small test case, compile & run it under the sim, 
and then compile & run it on real hardware.  if they behave the same, then 
ship it.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]