This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb/configure: Replace hardcoded -ldl with check based on dlfcn.h availability
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: pavel dot v dot chupin at gmail dot com
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 16 May 2013 16:04:42 +0200 (CEST)
- Subject: Re: [PATCH] gdb/configure: Replace hardcoded -ldl with check based on dlfcn.h availability
- References: <CANwJu1-LGhEaeA3Mmi37UkLZOAqEFpzFpKaKzL3MVA2WORdR7Q at mail dot gmail dot com> <CANwJu18MP86hi3etqskPSR3Pt6tPEZCSndzW2No_9ZHEig0AHQ at mail dot gmail dot com> <201305061230 dot r46CU0P4006086 at glazunov dot sibelius dot xs4all dot nl> <CANwJu1_HerKDCXB4gWAXMQY5TBe++X1A2bFSPcj+xg+MGnYQtA at mail dot gmail dot com> <87a9nx5qv9 dot fsf at fleche dot redhat dot com> <201305141923 dot r4EJNvUE017192 at glazunov dot sibelius dot xs4all dot nl> <CANwJu1-W4XUF1mfZnXOa1UgcAP+d8nksJA8ke1FUtBQC2uH+Jw at mail dot gmail dot com>
> Date: Thu, 16 May 2013 10:47:14 +0400
> From: Pavel Chupin <pavel.v.chupin@gmail.com>
>
> On Tue, May 14, 2013 at 11:23 PM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
> >> From: Tom Tromey <tromey@redhat.com>
> >> Date: Tue, 14 May 2013 13:00:10 -0600
> >>
> >> Mark> The fix isn't quite right. OpenBSD for example has <dlfcn.h> but no
> >> Mark> libdl; dlopen(3) and friends live in libc.
> >>
> >> Pavel> Hi Mark,
> >> Pavel> Thanks for your comments. Please see new patch attached.
> >>
> >> Pavel> - LIBS="-ldl $LIBS"
> >> Pavel> + AC_CHECK_LIB(dl, dlopen)
> >>
> >> I think it is probably better to use AC_SEARCH_LIBS.
> >
> > That's indeed what the autoconf manual suggests.
>
> Please see attached.
>
> ChangeLog entry didn't change:
> 2013-05-16 Pavel Chupin <pavel.v.chupin@intel.com>
>
> Replace hardcoded -ldl with check for availability
> * acinclude.m4: Add check for dlopen in libdl.
> * configure.ac: Ditto.
> * configure: Regenerate.
>
> Is it OK for trunk?
Fine with me.