This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gdb/configure: Replace hardcoded -ldl with check based on dlfcn.h availability


> Date: Thu, 16 May 2013 10:47:14 +0400
> From: Pavel Chupin <pavel.v.chupin@gmail.com>
> 
> On Tue, May 14, 2013 at 11:23 PM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
> >> From: Tom Tromey <tromey@redhat.com>
> >> Date: Tue, 14 May 2013 13:00:10 -0600
> >>
> >> Mark> The fix isn't quite right.  OpenBSD for example has <dlfcn.h> but no
> >> Mark> libdl; dlopen(3) and friends live in libc.
> >>
> >> Pavel> Hi Mark,
> >> Pavel> Thanks for your comments. Please see new patch attached.
> >>
> >> Pavel> -    LIBS="-ldl $LIBS"
> >> Pavel> +    AC_CHECK_LIB(dl, dlopen)
> >>
> >> I think it is probably better to use AC_SEARCH_LIBS.
> >
> > That's indeed what the autoconf manual suggests.
> 
> Please see attached.
> 
> ChangeLog entry didn't change:
> 2013-05-16  Pavel Chupin  <pavel.v.chupin@intel.com>
> 
>         Replace hardcoded -ldl with check for availability
>         * acinclude.m4: Add check for dlopen in libdl.
>         * configure.ac: Ditto.
>         * configure: Regenerate.
> 
> Is it OK for trunk?

Fine with me.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]