This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[committed] Move comment "ELSE FALL THROUGH" to the right place


Hi,
When I am reading the hardware watchpoint code, I find a line of comment
looks in a wrong place.  After check the mail archives, I find that
Michael proposed a patch <http://sourceware.org/ml/gdb-patches/2011-02/msg00803.html>
to document the fall-through in gdb/i386-nat.c and Pedro suggested
to do the same to gdbserver/i386-low.c as it is duplicated of i386-nat.c.
Michael committed the change in gdbserver/i386-low.c
<http://sourceware.org/ml/gdb-patches/2011-02/msg00847.html>, but it
was in a wrong place.  This patch is to fix it.  Committed.

gdb/gdbserver:

2013-05-17  Yao Qi  <yao@codesourcery.com>

	* i386-low.c (i386_length_and_rw_bits): Move the comment to
	the right place.
---
 gdb/gdbserver/i386-low.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gdb/gdbserver/i386-low.c b/gdb/gdbserver/i386-low.c
index 4ec41fc..86ec5d8 100644
--- a/gdb/gdbserver/i386-low.c
+++ b/gdb/gdbserver/i386-low.c
@@ -243,10 +243,10 @@ Invalid hardware breakpoint type %d in i386_length_and_rw_bits.\n",
 	return (DR_LEN_2 | rw);
       case 4:
 	return (DR_LEN_4 | rw);
-	/* ELSE FALL THROUGH */
       case 8:
         if (TARGET_HAS_DR_LEN_8)
  	  return (DR_LEN_8 | rw);
+	/* ELSE FALL THROUGH */
       default:
 	error ("\
 Invalid hardware breakpoint length %d in i386_length_and_rw_bits.\n", len);
-- 
1.7.7.6


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]