This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list]
- From: Tom Tromey <tromey at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Keith Seitz <keiths at redhat dot com>, "gdb-patches\ at sourceware dot org ml" <gdb-patches at sourceware dot org>
- Date: Fri, 17 May 2013 10:27:08 -0600
- Subject: Re: [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list]
- References: <CADPb22Sj_5Bp+FhoQYk_9vR5c1D3fXsw4gLFu7v+jmDNSaOPFg at mail dot gmail dot com> <5191340B dot 60100 at redhat dot com> <519156F5 dot 5090000 at redhat dot com> <5193C786 dot 4000207 at redhat dot com> <5193E2DC dot 5000200 at redhat dot com> <m3r4h7kh4p dot fsf at redhat dot com> <51941E85 dot 8010104 at redhat dot com> <20130516053008 dot GA5555 at adacore dot com> <20130516054906 dot GB5555 at adacore dot com> <5194FE2A dot 7000205 at redhat dot com> <20130517051435 dot GC4017 at adacore dot com>
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> I suspect we are going to find a large number of issues in
Joel> ada-lang, simply because I never quite grasped the fact that
Joel> cleanups should not be leaked under normal execution (only
Joel> when an exception is raised, in which case they get automatically
Joel> performed).
The checker found two -- the one you fixed in
ada_make_symbol_completion_list, and also a dangling cleanup in
old_renaming_is_invisible. This one seemed hard to fix and so
in my patch series I just punted on it by marking it with
the dangling_cleanup attribute.
Tom