This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFA: fix gdb_assert caused by 'catch signal ...' and fork
- From: Pedro Alves <palves at redhat dot com>
- To: Philippe Waroquiers <philippe dot waroquiers at skynet dot be>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 17 May 2013 19:17:56 +0100
- Subject: Re: RFA: fix gdb_assert caused by 'catch signal ...' and fork
- References: <1368136582 dot 30058 dot 7 dot camel at soleil> <518D2C4F dot 8070102 at redhat dot com> <1368736234 dot 2225 dot 30 dot camel at soleil>
On 05/16/2013 09:30 PM, Philippe Waroquiers wrote:
>>> + (void) wait(NULL);
>> Missing space before parens. (do you really need the cast?)
> space added.
> I added the cast to explicitely show that the return value is ignored.
> I might instead not ignore it if you think this is needed/better.
IMO, that's more noise than signal. We ignore return values in
many many cases, and don't do that (including other wait calls in
the testsuite).
> I also added a comment in breakpoint.c, to explain why
> the bp_loc_other locations are not removed.
>
> Ok to apply ?
Looks good to me. Give it a couple days more, in case Doug or
others wants to comment, and check it in then.
Thanks,
--
Pedro Alves