This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Make cu/tu functions in dwarf.exp take a list of options
- From: Doug Evans <dje at google dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>
- Date: Fri, 17 May 2013 11:20:43 -0700
- Subject: Re: [RFA] Make cu/tu functions in dwarf.exp take a list of options
- References: <yjt2obc9frdv dot fsf at ruffy dot mtv dot corp dot google dot com> <871u95qy90 dot fsf at fleche dot redhat dot com>
On Fri, May 17, 2013 at 11:04 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Doug> Ok to check in?
> Doug> Regression tested on amd64-linux.
>
> Looks good to me.
>
> Doug> 2013-05-17 Doug Evans <dje@google.com>
>
> Doug> * lib/dwarf.exp (Dwarf): New variable _abbrev_section.
> Doug> (_handle_DW_TAG): Use it.
> Doug> (cu): Replace parameters is_64, version, addr_size with options.
> Doug> All callers updated. Add Fission support.
>
> I thought we were supposed to list all the changed files, even in this
> case. If not, it would be nice to know, so I can stop doing that in the
> future.
I've always gone by this in standards.texi.
I don't see any amendment to this in the two wiki pages on coding standards.
[OTOH I haven't been using uppercase for parameter names, but that's typical
in gdb changelogs.]
@node Simple Changes
@subsection Simple Changes
Certain simple kinds of changes don't need much detail in the change
log.
When you change the calling sequence of a function in a simple fashion,
and you change all the callers of the function to use the new calling
sequence, there is no need to make individual entries for all the
callers that you changed. Just write in the entry for the function
being called, ``All callers changed''---like this:
@example
* keyboard.c (Fcommand_execute): New arg SPECIAL.
All callers changed.
@end example