This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: contribution checklist in the wiki


Hi Pedro,

Thanks for you works.


I have a question about format of changelog:
2013-12-12  John Doe  <johndoe@some.email.address>

        PR gdb/9999

        * breakpoint.c (handle_some_event): Remove reference to<line
wrap at or before column 79>

If I remember is right, some people told me that there should not have
a empty line after "PR xxx".
And I checked the changelog, some of them have empty line and others don't have.

So does it need a empty line after "PR xxx"?


And I have another question is about [RFC].  Where should it be sent
to, gdb or gdb-patches?

Best,
Hui

On Sat, May 18, 2013 at 12:37 AM, Pedro Alves <palves@redhat.com> wrote:
> Guys,
>
> I've created a new page in the wiki:
>
>  http://sourceware.org/gdb/wiki/ContributionChecklist
>
> This was heavily borrowed from glibc's own contribution checklist.
> (I asked them if they were okay before doing it.)
>
> At present, some of the info there duplicates what gdb/CONTRIBUTE
> says (but in different wording).  I expect it to grow some, and I'd
> rather keep it dynamic, without formal review/checking steps, which
> IMO for this sort of think is a too heavy process.
> I tailored the original text to make it fitter for gdb, but it's
> possible/likely there are things that need more editing to make
> it even fitter.
>
> I've been noticing that I often find myself pointing at the same
> little mistakes over different submissions.  E.g., pointing at
> need to mention changes in NEWS.  As I notice these patterns, I'll
> add them to the wiki.  I invite others to do the same.
>
> Thanks,
> --
> Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]