This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list]
- From: Tom Tromey <tromey at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 20 May 2013 08:47:46 -0600
- Subject: Re: [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list]
- References: <519156F5 dot 5090000 at redhat dot com> <5193C786 dot 4000207 at redhat dot com> <5193E2DC dot 5000200 at redhat dot com> <m3r4h7kh4p dot fsf at redhat dot com> <51941E85 dot 8010104 at redhat dot com> <20130516053008 dot GA5555 at adacore dot com> <20130516054906 dot GB5555 at adacore dot com> <5194FE2A dot 7000205 at redhat dot com> <20130517051435 dot GC4017 at adacore dot com> <87ehd5r2qr dot fsf at fleche dot redhat dot com> <20130520052818 dot GK4017 at adacore dot com>
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> Do you see something obviously wrong with the attached patch?
Joel> I haven't tested it yet, and I am not sure how much I can test it,
Joel> given that old-style renamings have been replaced 6 years ago.
Joel> I was looking at the option of removing support for them, but
Joel> I actually know of some users still using an ancient version
Joel> of the compiler but with a new version of the debugger...
For some reason I thought the function needed to leave a dangling
cleanup, but I see now I was mistaken.
It looks good to me.
Tom