This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Checked in: [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list]
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 21 May 2013 09:43:34 +0400
- Subject: Checked in: [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list]
- References: <5193E2DC dot 5000200 at redhat dot com> <m3r4h7kh4p dot fsf at redhat dot com> <51941E85 dot 8010104 at redhat dot com> <20130516053008 dot GA5555 at adacore dot com> <20130516054906 dot GB5555 at adacore dot com> <5194FE2A dot 7000205 at redhat dot com> <20130517051435 dot GC4017 at adacore dot com> <87ehd5r2qr dot fsf at fleche dot redhat dot com> <20130520052818 dot GK4017 at adacore dot com> <87ehd1ogh9 dot fsf at fleche dot redhat dot com>
> Joel> Do you see something obviously wrong with the attached patch?
> Joel> I haven't tested it yet, and I am not sure how much I can test it,
> Joel> given that old-style renamings have been replaced 6 years ago.
> Joel> I was looking at the option of removing support for them, but
> Joel> I actually know of some users still using an ancient version
> Joel> of the compiler but with a new version of the debugger...
>
> For some reason I thought the function needed to leave a dangling
> cleanup, but I see now I was mistaken.
> It looks good to me.
Cool, thanks! Attached is what I checked in, after a round of testing on
x86_64-linux.
gdb/ChangeLog:
* ada-lang.c (old_renaming_is_invisible): Fix cleanup leak.
Thanks again for pointing this cleanup leak out.
--
Joel