This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix DLL unload events in MinGW GDB
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 22 May 2013 19:19:09 +0300
- Subject: Re: [RFA] Fix DLL unload events in MinGW GDB
- References: <83li7ax1a0 dot fsf at gnu dot org> <20130520105302 dot GS4017 at adacore dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Mon, 20 May 2013 14:53:02 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
>
> > So it looks like the call to solib_add inside handle_unload_dll is the
> > culprit. And indeed, the trivial one-liner below is enough to fix
> > both stop-on-solib-events and "catch unload" for me.
> >
> > OK to commit (with ChangeLog)? Branch also?
>
> That looks correct to me. The solib_add call will be done by the
> core infrastructure (via infrun's handling of the TARGET_WAITKIND_LOADED
> event, calling handle_solib_event).
Committed to the trunk.
> For the gdb-7.6 branch, you'll need to:
> - Create a GDB PR describing the issue being fixed;
> - Update the gdb-7.6 release page to add an entry succinctly
> describing the fix:
> http://sourceware.org/gdb/wiki/GDB_7.6_Release
I decided that this is too much overhead for a problem that no one
else reported ;-)
> For the record, I tested this patch on x86-windows using AdaCore's
> testsuite, JIC, and found no regression.
Thanks.