This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Fix DLL unload events in MinGW GDB


> Date: Mon, 20 May 2013 14:53:02 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
> 
> > So it looks like the call to solib_add inside handle_unload_dll is the
> > culprit.  And indeed, the trivial one-liner below is enough to fix
> > both stop-on-solib-events and "catch unload" for me.
> > 
> > OK to commit (with ChangeLog)?  Branch also?
> 
> That looks correct to me. The solib_add call will be done by the
> core infrastructure (via infrun's handling of the TARGET_WAITKIND_LOADED
> event, calling handle_solib_event).

Committed to the trunk.

> For the gdb-7.6 branch, you'll need to:
>   - Create a GDB PR describing the issue being fixed;
>   - Update the gdb-7.6 release page to add an entry succinctly
>     describing the fix:
>     http://sourceware.org/gdb/wiki/GDB_7.6_Release

I decided that this is too much overhead for a problem that no one
else reported ;-)

> For the record, I tested this patch on x86-windows using AdaCore's
> testsuite, JIC, and found no regression.

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]