This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix 64x32 handling in gdbserver/linux-x86-low.c:ps_get_thread_area


Fun.  Thanks for the detailed analysis.

On 05/25/2013 02:25 AM, Doug Evans wrote:

> -    *(int *)base = desc[1];
> +    /* Ensure we properly extend the value to 64-bits for x86_64.  */
> +    *base = (void*) (uintptr_t) desc[1];

missing space: 'void *'.

Otherwise OK.

Thanks,
-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]