This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix 64x32 handling in gdbserver/linux-x86-low.c:ps_get_thread_area
- From: Pedro Alves <palves at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 25 May 2013 16:04:12 +0100
- Subject: Re: [patch] Fix 64x32 handling in gdbserver/linux-x86-low.c:ps_get_thread_area
- References: <yjt24ndru9yf dot fsf at ruffy2 dot mtv dot corp dot google dot com>
Fun. Thanks for the detailed analysis.
On 05/25/2013 02:25 AM, Doug Evans wrote:
> - *(int *)base = desc[1];
> + /* Ensure we properly extend the value to 64-bits for x86_64. */
> + *base = (void*) (uintptr_t) desc[1];
missing space: 'void *'.
Otherwise OK.
Thanks,
--
Pedro Alves