This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Mon, 2013-05-27 at 18:30 +0400, Joel Brobecker wrote: > > Additionally, I think the char buf; statement should read char *buf; in > > the patch. > > Clearly lots of errors in the patch I sent. Can you apply the changes > you suggested, recompile to make sure it at least builds, and post > again here. Because there is no testing involved, I'd like more people > to have a chance to review it before it gets checked in. > > Thank you, Ok, updated patch and ChangeLog entry attached.
Attachment:
ChangeLog.solve_PATH_MAX_issue
Description: Text document
--- a/gdb/nto-tdep.c +++ b/gdb/nto-tdep.c @@ -147,9 +147,10 @@ nto_find_and_open_solib (char *solib, unsigned o_flags, char **temp_pathname) void nto_init_solib_absolute_prefix (void) { - char buf[PATH_MAX * 2], arch_path[PATH_MAX]; + char *buf; char *nto_root, *endian; const char *arch; + struct cleanup *old_chain; nto_root = nto_target (); if (strcmp (gdbarch_bfd_arch_info (target_gdbarch ())->arch_name, "i386") == 0) @@ -172,10 +173,11 @@ nto_init_solib_absolute_prefix (void) == BFD_ENDIAN_BIG ? "be" : "le"; } - xsnprintf (arch_path, sizeof (arch_path), "%s/%s%s", nto_root, arch, endian); - - xsnprintf (buf, sizeof (buf), "set solib-absolute-prefix %s", arch_path); + buf = xstrprintf ("set solib-absolute-prefix \"%s/%s%s\"", + nto_root, arch, endian); + old_chain = make_cleanup (xfree, buf); execute_command (buf, 0); + do_cleanups (old_chain); } char **
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |