This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Remove unused parameter in remote_check_symbols.


>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> 2013-05-28  Yao Qi  <yao@codesourcery.com>

Yao> 	* remote.c (remote_check_symbols): Remove unused parameter
Yao> 	'objfile'.
Yao> 	Declaration update.
Yao> 	(remote_start_remote, remote_new_objfile): Caller update.

It seems reasonable to me.

I suppose this code could use the objfile argument if the call to
remote_check_symbols in remote_start_remote looped over all the
objfiles.

That seems like a minor optimization though.

I noticed that this code doesn't handle the case where an objfile is
destroyed.  That would seem to potentially leave the remote with an
invalid address.  But maybe this doesn't matter for some reason?

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]