This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Remove unused parameter in remote_check_symbols.
- From: Yao Qi <yao at codesourcery dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Wed, 29 May 2013 18:04:42 +0800
- Subject: Re: [PATCH] Remove unused parameter in remote_check_symbols.
- References: <1369721603-5253-1-git-send-email-yao at codesourcery dot com> <87mwrfxhdx dot fsf at fleche dot redhat dot com>
On 05/28/2013 11:18 PM, Tom Tromey wrote:
I suppose this code could use the objfile argument if the call to
remote_check_symbols in remote_start_remote looped over all the
objfiles.
Tom,
IIUC, there is only one objfile, symfile_objfile, when
remote_check_symbols is called in remote_start_remote. After that, when
a new objfile is loaded each time, remote_check_symbols is called again.
That seems like a minor optimization though.
I noticed that this code doesn't handle the case where an objfile is
destroyed. That would seem to potentially leave the remote with an
invalid address. But maybe this doesn't matter for some reason?
When an objfile is destroyed (shared lib is unloaded, for example), the
address becomes unreachable to inferior. We don't have to worry about
it, right?
--
Yao (éå)