This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch v4 1/3] Create remove-symbol-file command.


Hi,

On 05/29/2013 02:08 PM, Blanc, Nicolas wrote:
Hi Luis,

Thanks for your feedback. I'll fix the nits.

I'm thinking, with a command called "remove-symbol-file" i would expect to provide some kind of filename to this command. Should the user also be able to state a DSO name here and have it unloaded?
Maybe have the name translated to the base address used to unload the library internally?

The first address parameter of the add-symbol-file command is a better way to identify the file to remove than the file name because a file can be loaded multiple times at different addresses -- this case is important for me. The user knows the "start address" very well since he typed it in for adding the file. So I see no real benefit of adding a file-name parameter.

I see. That was mostly a suggestion. If it problematic to implement it that way, then i suppose it is OK to use solely the base address.


Keeping the current syntax would be ok with you?

Sure, that looks good to me.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]