This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Exit code of exited inferiors
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Simon Marchi <simon dot marchi at ericsson dot com>
- Cc: gdb-patches at sourceware dot org, marc dot khouzam at ericsson dot com
- Date: Wed, 29 May 2013 18:57:58 +0300
- Subject: Re: [PATCH v2] Exit code of exited inferiors
- References: <51A5160D dot 40800 at ericsson dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Tue, 28 May 2013 16:39:41 -0400
> From: Simon Marchi <simon.marchi@ericsson.com>
> CC: Marc Khouzam <marc.khouzam@ericsson.com>
>
> This is the second version of my patch to add the exit-code in the
> -list-thread-groups output. New in v2: NEWS file, documentation and a
> test case. I didn't find any test about -list-thread-groups so I created it.
>
> As far as I know, this does not break any other test.
>
> Changelog:
>
> 2013-05-28 Simon Marchi <simon.marchi@ericsson.com>
>
> * gdb/NEWS: Announce new exit-code field.
> * gdb/doc/gdb.texinfo: Document new exit-code field.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
You should state the name of the node in which you made the change, as
if it were a function (i.e. in parentheses).
> * gdb/inferior.c (exit_inferior_1): Remove exit code clear.
> (inferior_appeared): Add exit code clear.
> * gdb/mi/mi-main.c (print_one_inferior): Add printing of the exit code.
> * gdb/testsuite/gdb.mi/mi-list.exp: New file, added test case for
> -list-thread-groups.
OK for the documentation part, after you have fixed the above gotcha.
Thanks.