This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 2/7 take 2] API for inhibiting section map updates
- From: Pedro Alves <palves at redhat dot com>
- To: gdb-patches at sourceware dot org, Gary Benson <gbenson at redhat dot com>
- Cc: Tom Tromey <tromey at redhat dot com>
- Date: Wed, 29 May 2013 18:17:58 +0100
- Subject: Re: [RFA 2/7 take 2] API for inhibiting section map updates
- References: <20130516144340 dot GA2105 at blade dot nx> <20130516144813 dot GC2105 at blade dot nx> <87mwrpohnv dot fsf at fleche dot redhat dot com> <20130524074737 dot GB4602 at blade dot nx>
On 05/24/2013 08:47 AM, Gary Benson wrote:
> /* Update the table in exec_ops, used to read memory. */
> ALL_OBJFILE_OSECTIONS (objfile, s)
> @@ -1291,11 +1300,14 @@ static void
> update_section_map (struct program_space *pspace,
> struct obj_section ***pmap, int *pmap_size)
> {
> + struct objfile_pspace_info *pspace_info;
> int alloc_size, map_size, i;
> struct obj_section *s, **map;
> struct objfile *objfile;
>
> - gdb_assert (get_objfile_pspace_data (pspace)->objfiles_changed_p != 0);
> + pspace_info = get_objfile_pspace_data (current_program_space);
Shouldn't this be 'pspace' instead of 'current_program_space'?
> + gdb_assert (pspace_info->section_map_dirty != 0
> + || pspace_info->new_objfiles_available != 0);
>
--
Pedro Alves