This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 3/7 take 2] New gdbserver functionality
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>, gdb-patches at sourceware dot org
- Date: Wed, 29 May 2013 19:50:22 +0100
- Subject: Re: [RFA 3/7 take 2] New gdbserver functionality
- References: <20130524074613 dot GA4602 at blade dot nx>
On 05/16/2013 03:48 PM, Gary Benson wrote:
> + sep = strchr (annex, '=');
> + if (!sep)
Please write
if (sep == NULL)
There are more instances of this in the patch.
> + break;
> +
> + len = sep - annex;
> + if (len == 5 && !strncmp (annex, "start", 5))
strncmp does not return a boolean. Please write:
> + if (len == 5 && strncmp (annex, "start", 5) == 0)
> + else if (len == 4 && !strncmp (annex, "prev", 4))
Ditto.
Otherwise looks good to me too.
There should be a NEWS entry for the new RSP feature too though.
--
Pedro Alves