This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Remove parse_print_values


On 05/31/2013 03:16 PM, Yao Qi wrote:

> 	* mi/mi-cmds.h (mi_no_values, mi_simple_values, mi_all_values):
> 	Remove the declarations.
> 	* mi/mi-parse.c: Moved from mi-cmd-var.c.

"Moved what?", he asks.  :-)

 	* mi/mi-parse.c (XXX, YYY, ZZZ): Moved from mi-cmd-var.c.

>    frame = get_selected_frame (NULL);
> -  print_value = parse_print_values (argv[raw_arg]);
> +  print_value = mi_parse_values_option (argv[raw_arg]);

Sorry to be picky, but the "mi_parse_values_option" naming to me
has a weaker connection with "enum print_values" than "parse_PRINT_VALUES".
I'd suggest calling the new shared function "mi_parse_print_values".
WDYT?  This is fine with me with that change.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]