This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH, ppc64] Fix stepping into calls via thunk
- From: Pedro Alves <palves at redhat dot com>
- To: lgustavo at codesourcery dot com
- Cc: "'gdb-patches at sourceware dot org'" <gdb-patches at sourceware dot org>
- Date: Wed, 05 Jun 2013 15:56:50 +0100
- Subject: Re: [PATCH, ppc64] Fix stepping into calls via thunk
- References: <51AE5D6E dot 7080107 at codesourcery dot com>
On 06/04/2013 10:34 PM, Luis Machado wrote:
> For ppc64, though, what GDB thinks is the address of the real function isn't really the address of the function, but a pointer to a function descriptor. We need to fetch the real function's address from that descriptor.
>
> This patch does exactly that, and it is very simple.
Looks right to me, though I'm no ppc expert.
> The use of current_target made me scratch my head a little. I seem to recall we dropped further uses of this variable in the past, but this hook still seems to require the target_ops to be passed. Is this OK?
That's fine. See solib-svr4.c for the uses that need to pass in
something else. (You'll end up in bfd-target.c.)
--
Pedro Alves