This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/5] Move code to get_traceframe_location.


On 06/07/2013 02:08 PM, Yao Qi wrote:
> This patch is a refactor patch. 

Mainly, but not only.

> +static struct bp_location *
> +get_traceframe_location (int *stepping_frame_p)
> +{

> +  if (tracepoint_number == -1)
> +    error (_("No current trace frame."));

> +}
> +


> @@ -2982,46 +3024,19 @@ all_tracepoint_actions_and_cleanup (struct breakpoint *t)
>  static void
>  trace_dump_command (char *args, int from_tty)
>  {

> -  if (tracepoint_number == -1)
> -    {
> -      warning (_("No current trace frame."));
> -      return;
> -    }

There's a behavior change here.  Can you split that out
to a separate, preparatory patch, please?

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]