This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1 OF 2] fix start and stop time in trace status


On 06/10/2013 01:45 PM, Dmitry Kozlov wrote:
> Hi Pedro,
> some time ago we already discussed these patches, could you please 
> review them again.

It's always useful to linked to the previous discussion,
and list what changed in new revisions.

> diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
> index 604a414..772bdb8 100644
> --- a/gdb/gdbserver/ChangeLog
> +++ b/gdb/gdbserver/ChangeLog
> @@ -1,3 +1,9 @@
> +2013-06-10  Dmitry Kozlov <ddk@codesourcery.com>
> +
> +	Fix trace-status to output proper start-time and stop-time.
> +	* gdbserver/tracepoint.c (cmd_qtstatus): Modify trace-status output to
> +	output start time and stop time in hex as gdb expects.

Files paths mentioned in ChangeLog entries are relative to the
ChangeLog file path.  As this goes to gdb/gdbserver/ChangeLog,
it should read:

	* tracepoint.c ...

Otherwise this fine with me to.

Thanks,
-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]