This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v3] don't keep a gdb-specific date


>> echo '#include "server.h"' >> version.c-tmp

Pedro> Can this be just version.h, like GDB's ?

Yes.  I fixed it.

>> -	echo 'const char version[] = "'"`sed q ${srcdir}/../version.in`"'";' >> version.c-tmp
>> +	echo 'const char version[] = "'"`sed q version.tmp`"'";' >> version.c-tmp
>> echo 'const char host_name[] = "$(host_alias)";' >> version.c-tmp
>> mv version.c-tmp version.c
>> +	rm -f version.tmp
>> version.o: version.c $(server_h)

Pedro> Then we could move all this shell code to a script under
Pedro> common/ that would be called by both gdb and gdbserver.  Or
Pedro> a Makefile fragment that's sourced by both Makefiles with
Pedro> the version.c rule (is the version.o rule in gdbserver still
Pedro> necessary?).  Anyway, please don't feel compelled to do that.
Pedro> It can always be done afterwards.  This version is already
Pedro> super fine with me.

I made a shell script and removed the version.o target.

I also noticed that I'd neglected to update doc/Makefile.in.  The new
patch does that.  I'll send it momentarily.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]