This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [commit] Improved linker-debugger interface
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: Tom Tromey <tromey at redhat dot com>, gdb-patches at sourceware dot org, Jan Kratochvil <jan dot kratochvil at redhat dot com>, Pedro Alves <palves at redhat dot com>
- Date: Wed, 26 Jun 2013 11:53:35 -0700
- Subject: Re: [commit] Improved linker-debugger interface
- References: <20130516144340 dot GA2105 at blade dot nx> <20130604133819 dot GA25892 at blade dot nx> <20130625205350 dot GA28973 at adacore dot com> <m3obatx5b3 dot fsf at redhat dot com> <87hagkrih3 dot fsf at fleche dot redhat dot com> <m37ghgx0dv dot fsf at redhat dot com>
> What could be done is to check gdbarch_stap_is_single_operand_p. This
> is a mandatory function that needs to be set by the target. If it
> doesn't exist, then we know that the target lacks SDT support.
>
> Before I work on a patch, I'd like to know what you think.
I agree that it would be friendlier to make sure stap-support is
activated before trying to use it. If the warning is then only
possible when stap support is in, and denotes a bug in either GDB
or the executable, then I'm all for keeping it.
I also like Tom's suggestion of expanding the warning to contain
the pieces of information he suggested. I had a recent experience
where the warning was missing a critical piece of information and
that prevented me from diagnosing the problem remotely.
--
Joel