This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/7] gdbserver, common: conditionally include the unistd.h
- From: Pedro Alves <palves at redhat dot com>
- To: Mircea Gherzan <mircea dot gherzan at intel dot com>
- Cc: tromey at redhat dot com, jan dot kratochvil at redhat dot com, gdb-patches at sourceware dot org
- Date: Fri, 28 Jun 2013 19:17:50 +0100
- Subject: Re: [PATCH 1/7] gdbserver, common: conditionally include the unistd.h
- References: <1372322622-3216-1-git-send-email-mircea dot gherzan at intel dot com> <1372322622-3216-2-git-send-email-mircea dot gherzan at intel dot com> <51CC22C2 dot 2020906 at redhat dot com> <51CC8B72 dot 3070208 at redhat dot com> <51CDA7BD dot 2060802 at intel dot com>
On 06/28/2013 04:11 PM, Mircea Gherzan wrote:
> On 27.06.2013 20:58, Pedro Alves wrote:
>> On 06/27/2013 12:32 PM, Pedro Alves wrote:
>>> On 06/27/2013 09:43 AM, Mircea Gherzan wrote:
>>>> 2013-06-25 Mircea Gherzan <mircea.gherzan@intel.com>
>>>>
>>>> * common/agent.c: Conditionally include unistd.h.
>>>>
>>>> gdbserver/
>>>> * hostio.c: Conditionally include unistd.h and define PATH_MAX
>>>> if unistd.h is not available.
>>>> * tracepoint.h: Conditionally include unistd.h.
>>>
>>> Hmm, I've discussed this PATH_MAX issue before.
>>> I think we should pull in the unistd and pathmax modules from
>>> gnulib. In hostio.c, we should cap the max path len to the max
>>> of PATH_MAX (if defined, it won't on the Hurd), and the packet buffer
>>> size. Let me post a series for that.
>>
>> Posted at:
>>
>> http://sourceware.org/ml/gdb-patches/2013-06/msg00838.html
>>
>> Could you give it a try?
>
> Work fine in my case, thanks!
Excellent!
> Please commit it so I can rebase my series on top of it.
I'll apply this Monday. (I'm about to end my day, so I'd prefer not
rushing this in Friday evening, and leave the tree broken for the
weekend in case I don't get to park in front of the computer.)
Meanwhile, you could rebase on the branch I pushed to github, if
you're using git.
--
Pedro Alves