This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Implement SDT (SystemTap probes) support for IA-64
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Gary Benson <gbenson at redhat dot com>, Tom Tromey <tromey at redhat dot com>
- Date: Sat, 29 Jun 2013 21:37:51 -0300
- Subject: Re: [PATCH] Implement SDT (SystemTap probes) support for IA-64
- References: <m3bo6twg2x dot fsf at redhat dot com> <20130626184951 dot GI5326 at adacore dot com>
On Wednesday, June 26 2013, Joel Brobecker wrote:
> Many thanks for the patch. I am pretty sure I would have spent hours
> figuring it out, and then implementing the necessary bits.
>
> I confirm that this works for me as well.
No problem, Joel. Thanks for testing.
>> 2013-06-26 Sergio Durigan Junior <sergiodj@redhat.com>
>>
>> * ia64-linux-tdep.c: Include <ctype.h>.
>> (ia64_linux_stap_is_single_operand): New function.
>> (ia64_linux_init_abi): Initialize SystemTap related attributes.
>
> FWIW, this patch looks OK to me.
On Thursday, June 27 2013, Tom Tromey wrote:
> Sergio> 2013-06-26 Sergio Durigan Junior <sergiodj@redhat.com>
> Sergio> * ia64-linux-tdep.c: Include <ctype.h>.
> Sergio> (ia64_linux_stap_is_single_operand): New function.
> Sergio> (ia64_linux_init_abi): Initialize SystemTap related attributes.
>
> Thanks Sergio.
No problem.
> Sergio> + set_gdbarch_stap_is_single_operand (gdbarch, ia64_linux_stap_is_single_operand);
>
> I think this line needs to be split.
Sorry, fixed.
> This patch looks ok to me, assuming it passes Joel's testing.
Yes, according to the previous message from Joel, it works.
Thanks to all, the patch has been checked-in.
http://sourceware.org/ml/gdb-cvs/2013-06/msg00207.html
--
Sergio