Re: [PATCH] fix PR 15180 "May only run agent-printf on the target"

[Hui Zhu <teawater at gmail dot com>]

Hi Pedro,

Thanks for your review.

On Thu, Jun 27, 2013 at 1:58 AM, Pedro Alves <palves@redhat.com> wrote:
> On 06/17/2013 08:47 AM, Hui Zhu wrote:
>> Hi,
>>
>> This patch is for PR 15180 too.  Because it depends on patch in
>> http://sourceware.org/ml/gdb-patches/2013-06/msg00139.html
>> So I post it in another thread.
>>
>> It make dprintf_after_condition_true doesn't do actions if dprintf
>> style is agent.  Because the actions is already did in agent.
>
> If dprintf style is agent, then the target doesn't report events
> for such hits.  If we happen to see a trap reported for the
> same address as another breakpoint, the trap is surely not explained
> by the dprintf.  IOW, we shouldn't have a bpstat a dprintf w/ style
> agent at all.  What is need is to override the breakpoint_hit method
> of dprintf_breakpoint_ops to always return false for agent style dprintfs.
>
> Or maybe I'm missing something.  I have a hard time going from
> the bug description in the PR to the patch.

OK.  I add dprintf_check_status in the new patch according to your comments.

>
>>
>> The test patch test the issue about 15180.
>
> Hmm, I get:
>
> Running target native-gdbserver
> Using ../../../src/gdb/testsuite/boards/../boards/native-gdbserver.exp as board description file for target.
> Using ../../../src/gdb/testsuite/config/gdbserver.exp as tool-and-target-specific interface file.
> Running ../../../src/gdb/testsuite/gdb.base/dprintf-same-addr.exp ...
> FAIL: gdb.base/dprintf-same-addr.exp: agent: First continue (the program exited)
> FAIL: gdb.base/dprintf-same-addr.exp: agent: Second continue (the program is no longer running)
> FAIL: gdb.base/dprintf-same-addr.exp: agent: check i
>
>                 === gdb Summary ===
>
> # of expected passes            16
> # of unexpected failures        3
> # of unsupported tests          1
>

I am sorry that didn't talk this test very clear.  It depend on the
patches in http://sourceware.org/ml/gdb-patches/2013-06/msg00367.html
Could you patch those patches and try again?

Thanks,
Hui

2013-06-30  Hui Zhu  <hui@codesourcery.com>

	PR gdb/15180
	* breakpoint.c (dprintf_check_status): New function.
	(initialize_breakpoint_ops): Set dprintf_check_status.

2013-06-30  Hui Zhu  <hui@codesourcery.com>

	PR gdb/15180
	* gdb.base/dprintf-same-addr.c: New file.
	* gdb.base/dprintf-same-addr.exp: New file.

>
>
>>
>> Thanks,
>> Hui
>>
>> 2013-06-17  Hui Zhu  <hui@codesourcery.com>
>>
>>       PR gdb/15180
>>       * breakpoint.c (dprintf_after_condition_true): Check dprintf style
>>       before do actions.
>>
>> 2013-06-17  Hui Zhu  <hui@codesourcery.com>
>>
>>       PR gdb/15180
>>       * gdb.base/dprintf-same-addr.c: New file.
>>       * gdb.base/dprintf-same-addr.exp: New file.
>>
>
>
> --
> Pedro Alves

Attachment: dprintf-same-addr.txt
Description: Text document

Attachment: dprintf-same-addr-test.txt
Description: Text document