This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/3] Detect GDB is in cygwin


On Thu, Aug 01, 2013 at 03:51:23PM +0800, Yao Qi wrote:
>On 07/30/2013 11:33 PM, Eli Zaretskii wrote:
>> There's no need to probe that at configure time: this code can always
>> be compiled on any MS-Windows system.  The compiler doesn't care and
>> doesn't check at compile time whether there is in fact
>> NtQueryInformationFile function inside the DLL.
>
>OK.  If so, in configure.ac, we only need to check headers, and don't need
>AC_TRY_COMPILE at all.  Here is the updated one, with several changes,
>
> - Remove AC_TRY_COMPILE,
> - Include fewer headers in mingw-htep.c, and don't have to check them
>in configure.ac.
> - Rename is_in_cygwin to using_cygwin_pty,

This patch relies on low-level, unadvertised properties of the Cygwin DLL.
Are you sure it doesn't detect a cygwin pipe as a pty?

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]