This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Set entryval_error to NULL if entryval is set
- From: Tom Tromey <tromey at redhat dot com>
- To: Yao Qi <yao at codesourcery dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Mon, 05 Aug 2013 08:06:24 -0600
- Subject: Re: [PATCH] Set entryval_error to NULL if entryval is set
- References: <1375690566-7417-1-git-send-email-yao at codesourcery dot com>
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> 2013-08-05 Yao Qi <yao@codesourcery.com>
Yao> * stack.c (read_frame_arg): Set 'entryval_error' to NULL if
Yao> 'entryval' is set.
Yao> 2013-08-05 Yao Qi <yao@codesourcery.com>
Yao> * gdb.trace/collection.exp (gdb_collect_args_test): Set
Yao> "only" and "both" to 'print entry-values' before selecting
Yao> trace frame.
The bug fix part looks ok to me, but I think you need a special test
case in order to really test entry values. Or to put it another way,
what happens if this test is run with a compiler that doesn't emit entry
value information?
Tom