This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/5] [PR gdb/15224] Unify interactivity tests to use input_from_terminal_p:
- From: Pedro Alves <palves at redhat dot com>
- To: Muhammad Bilal <mbilal at codesourcery dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, jan dot kratochvil at redhat dot com
- Date: Tue, 13 Aug 2013 18:53:49 +0100
- Subject: Re: [PATCH 1/5] [PR gdb/15224] Unify interactivity tests to use input_from_terminal_p:
- References: <52032A06 dot 6000900 at codesourcery dot com>
On 08/08/2013 06:17 AM, Muhammad Bilal wrote:
>
> Currently commands are added to gdb history with out checking the
> interactive debugging
> In this patch we are performing the interactivity tests to use
> input_from_terminal_p.
Previous I had said:
> It'd be great to try that on
> GNU/Linux, mingw32 gdb running under cmd.exe, and mingw32 gdb under
> Cygwin bash, the latter with and without "set interactive-mode on".
> I suspect this change would fix history for the forced
> "set interactive-mode on" case too.
Did you try any of that?
> 2013-08-08 Muhammad Bilal <mbilal@codesourcery.com>
>
> PR gdb/15224
> * top.c (command_line_input): Unify interactivity tests to use
> input_from_terminal_p.
> * event-top.c (command_line_input): Likewise.
This is OK if it doesn't regress the modes mentioned above.
--
Pedro Alves