This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Refactor common/target-common into meaningful bits


I see some gotchas with this patch (on Makefile.in etc).

I'll get those fixed and will submit an updated version.

On 08/16/2013 11:49 AM, Luis Machado wrote:
Hi,

This is an updated version of the patch that drops the target-* naming,
creates a new directory named "target" under src/gdb and renames the
files target-<something>.* to <something.*.

Based on previous discussions, it seems this is what it should look like
in the future.

One of the differences now is the inclusion of, for example,
"target/resume.h" instead of "resume.h". It looks more intuitive this way.

Ok?

Luis

On 08/01/2013 02:09 PM, Luis Machado wrote:
Hi,

After the previous discussion
(http://sourceware.org/ml/gdb-patches/2013-07/msg00840.html), follows a
patch to refactor the ill-named target-common.[c|h] files into something
a bit more meaningful.

First, it seems like a good idea to stablish a  more meaningful
directory structure as well, so we are moving target-common.[c|h] from
the "common" dir to the new "target" dir. This new directory will hold
anything more backend-related. For now it contains only generic target
definitions and functions.

I've broken target-common.[c|h] into the following:

- target-resume.h: Definition for resume_kind.

- target-waitstatus.[c|h]: Definitions and code for anything related to
waitstatus.

- target-wait.h: A tiny bit that does not seem to fit properly in the
waitstatus files, so it is left here.

As usual, Makefile and other dependencies have been adjusted. Everything
builds fine and does not show any regressions.

The copyright headers have been adjusted and cleaned up to remove
contribution messages.

Comments over 70 columns have also been adjusted for this patch.

Thoughts?

Luis



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]