This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/ppc-aix] fix thread support breakage (was: "Re: [PATCH 4/5] powerpc64-aix ptrace64 when defined.")
- From: Joel Brobecker <brobecker at adacore dot com>
- To: David Edelsohn <dje dot gcc at gmail dot com>
- Cc: Raunaq 12 <raunaq12 at in dot ibm dot com>, GDB Patches <gdb-patches at sourceware dot org>, Mark Kettenis <mark dot kettenis at xs4all dot nl>, Ulrich Weigand <Ulrich dot Weigand at de dot ibm dot com>
- Date: Fri, 23 Aug 2013 06:34:15 -0700
- Subject: Re: [RFA/ppc-aix] fix thread support breakage (was: "Re: [PATCH 4/5] powerpc64-aix ptrace64 when defined.")
- References: <CAGWvnynVeLt6F-QREsP_CtQvwvtZgwqHxtcS6pn58LMf=AX=GA at mail dot gmail dot com> <OF91B6D42F dot B0CFCB9C-ON65257BC5 dot 004284AA-65257BC5 dot 0042F553 at in dot ibm dot com> <CAGWvnynzsNL--qPhHOhqZ912A4M9ZpXtT2JbjW4EHRodEXAF9Q at mail dot gmail dot com> <20130822233234 dot GA13292 at adacore dot com> <20130823004837 dot GC5221 at adacore dot com> <CAGWvnymjyCc9vFbh4+eNdr2mdxJYU0=LFC1-itC38SDKfRaG-w at mail dot gmail dot com>
> > gdb/ChangeLog:
> >
> > * rs6000-nat.c (rs6000_ptrace32): Cast "addr" to "uintptr_t"
> > instead of "long long" in call to ptrace64.
> >
> > Tested on ppc-aix in full 32bit mode (both GDB and inferior are
> > 32bit). I think the other scenario would be 64bit GDB debugging
> > a 32bit inferior, but I don't have a 64bit compiler to try it.
> >
> > I'd like to commit this patch, unless there are comments/suggestions.
>
> LGTM.
Thanks :)
> Is there a testcase that can be added to the GDB testsuite to catch
> this type of regression?
All testcases involving thread support should reveal this type of
failure. I cannot remember exactly how this patch was tested, but
ISTR that it couldn't be tested through the official testsuite,
for some reasons that were deemed reasonable...
--
Joel