This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH v2] Added file properties to windows gdb executable for all mingw32 builds.


> -----Original Message-----
> From: Pedro Alves [mailto:palves@redhat.com]
> Sent: Friday, August 23, 2013 3:42 PM
> To: Eli Zaretskii
> Cc: Bunk, Bernd; tromey@redhat.com; gdb-patches@sourceware.org
> Subject: Re: [PATCH v2] Added file properties to windows gdb executable
> for all mingw32 builds.
> 
> On 08/23/2013 02:27 PM, Eli Zaretskii wrote:
> >> Date: Fri, 23 Aug 2013 14:06:51 +0100
> >> From: Pedro Alves <palves@redhat.com> Right, I mean, other than the
> >> fact that the patch only enabled this on mingw, there's nothing in
> >> the feature itself that'd prevent it from working on Cygwin, afaik,
> >> as this is a Windows binary thing, not specific of MinGW's
> toolchain.
> >
> > The question is: do the Cygwin maintainers _want_ the Cygwin GDB have
> > all these resources linked into the binary.  Cygwin is a Posix
> > environment, where these attributes are neither expected nor (AFAIK)
> > used in any way.
> 
> I'm really just pointing out Cygwin as rationale for preferring
> windows-*.c as file name instead of mingw-*.  In my mind, given this is
> a Windows/PE feature, not specific of mingw, the file naming would
> reflect that.  That is, name the files for what they are, not for how
> they're used today.  If the Cygwin guys at some point want to link in
> the resources, then it'd be a no brainer to tweak configure.  If the
> files are called mingw-*, then such a change would be kind of awkward
> without a file rename.  But this is really bike shedding, not worth
> spending more cycles on it.  If you guys prefer mingw, then let's go
> with it.
Ok, I am also fine with windows-*, as long as I am not expected to do this Cygwin adaptation.  If they want this feature they will have it easy and they have the means to test it.  Perfect for both parties.  I will now rework the code according to the feedback from the last discussions.

> 
> --
> Pedro Alves

Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]