This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Added file properties to windows gdb executable for all mingw32 builds.
- From: Pedro Alves <palves at redhat dot com>
- To: "Bunk, Bernd" <bernd dot bunk at intel dot com>
- Cc: Eli Zaretskii <eliz at gnu dot org>, "tromey at redhat dot com" <tromey at redhat dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 26 Aug 2013 16:00:13 +0100
- Subject: Re: [PATCH v2] Added file properties to windows gdb executable for all mingw32 builds.
- Authentication-results: sourceware.org; auth=none
- References: <1377161766-8318-1-git-send-email-bernd dot bunk at intel dot com> <8361uxkbi9 dot fsf at gnu dot org> <52166564 dot 90605 at redhat dot com> <E2C54CDFBA86B845B3B075E2B2042A91202566E0 at IRSMSX106 dot ger dot corp dot intel dot com> <521773E9 dot 1060704 at redhat dot com> <E2C54CDFBA86B845B3B075E2B2042A9120256D16 at IRSMSX106 dot ger dot corp dot intel dot com>
On 08/26/2013 01:01 PM, Bunk, Bernd wrote:
>> From: Pedro Alves [mailto:palves@redhat.com]
>>>> See gdb/configure.ac, gdb/Makefile.in and gdbtk/gdb.rc etc.
>>>> Isn't this going to conflict on gdbtk builds?
>>> See above, yes it would.
>>
>> Well, it just looks to me that the gdbres.rc resource and the icon are
>> presently only used on Cygwin-hosts builds, because nobody bothered to
>> tweak that configure bit to make it work on mingw-hosts too. That bit
>> is there since at least 2000, and I believe MinGW host support came in
>> much after. Cygwin wanting pretty icons, but MinGW not is kind of
>> strange, wouldn't you say? :-)
>>
>> Do you have any hint at what one would need to do, if one were to
>> enable that icon resource on mingw too?
> I can offer to merge this icon into my mingw rc file in a later checkin.
Thanks. Note the icon should probably only be used for gdbtk/insight
builds, not plain command line gdb builds, and should probably stay in
the gdbtk/ dir. If it's possible to link in more than one rc file,
than there'd be no problem. But if that's not possible, then we'd
need something more magical...
But tbh I cannot even find the sources (icon or gdbtk folder). Someone checked in build rules for something that is not on the same branch (upstream/master). I am new to this gdb coding, but I would never do something like this...
The gdbtk/ directory is part of insight, which (currently) lives in
the same repository but in a different cvs module. You'll need to
"cvs ... co insight" instead of "cvs ... co gdb" to get it.
--
Pedro Alves