This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA, doc RFA] Fix symtab/15885
- From: Tom Tromey <tromey at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org, eliz at gnu dot org
- Date: Mon, 26 Aug 2013 09:49:42 -0600
- Subject: Re: [RFA, doc RFA] Fix symtab/15885
- Authentication-results: sourceware.org; auth=none
- References: <yjt2txifrixw dot fsf at ruffy dot mtv dot corp dot google dot com>
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> I think there is more cleanup to be had beyond reread_symbols,
Doug> but again I don't want this patch bogged down in that.
More evidence that reread_symbols should go the free_objfile route. I
agree it isn't needed for this fix though.
Doug> + if {[run_on_host "objcopy" [transform objcopy] "--remove-section .gdb_index --add-section .gdb_index=$index_file --set-section-flags .gdb_index=readonly ${program} ${program_with_index}"]} {
This line looks over-long.
Otherwise the patch looks fine to me.
Tom