This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] windows-nat.c: Don't install a deprecated_xfer_memory method.
- From: Pedro Alves <palves at redhat dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 26 Aug 2013 17:54:14 +0100
- Subject: Re: [PATCH] windows-nat.c: Don't install a deprecated_xfer_memory method.
- Authentication-results: sourceware.org; auth=none
- References: <20130823181245 dot 4023 dot 25651 dot stgit at brno dot lan> <001201cea048$e2f17ed0$a8d47c70$ at muller@ics-cnrs.unistra.fr> <521B87D8 dot 1040303 at redhat dot com>
On 08/26/2013 05:52 PM, Pedro Alves wrote:
> On 08/23/2013 10:36 PM, Pierre Muller wrote:
>> Hi Pedro,
>>
>> I think that your patch can be further enhanced by this change:
>> ReadProcessMemory and WriteProcessMemory
>> function both fail and report ERROR_PARTIAL_COPY
>> in GetLastError
>> if only a part of the requested memory was read/written.
>
> Interesting. It does sound like a good idea.
>
> However, could you send that as a separate patch, please?
And I meant to add for forgot -- that separate patch could
then also propose the same change for gdbserver too. :-)
> Otherwise, the single combined patch can potentially cause issues
> due to two logically unrelated changes: potential problems caused by
> not installing deprecated_xfer_memory anymore, and instead going
> through xfer_partial directly; and then potential problems due to
> that change. Keeping the patches separate allows for better
> bisecting for what might have caused a regression.
--
Pedro Alves