This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 5/5] testsuite for nds32 simulator


On Monday 08 July 2013 05:33:08 Wei-cheng Wang wrote:
> --- /dev/null
> +++ b/sim/testsuite/sim/nds32/000-sanity.s

i'm not sure if this ### prefix is coming from somewhere, but you don't need to 
use it if you don't want to.

> +# nds32 test sanity, expected to pass.
> +# mach:		all
> +# as:		-mbaseline=V3
> +# ld:		--defsym=_stack=0x3000000
> +# output:	pass\n
> +
> +	.include "utils.inc"
> +
> +	.text
> +	.global main
> +main:
> +	smw.adm $sp, [$sp], $sp, 10
> +
> +	la	$r0, .Lstring
> +	bal	puts
> +	movi	$r0, 0
> +
> +	lmw.bim $sp, [$sp], $sp, 10
> +	ret
> +
> +.Lstring:
> +	.string "pass\n"

your utils.inc has already set up macros like PASS and FAIL for marking a test 
as pass/fail.  why do you not use them in a lot of these tests ?
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]