This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: Fix build regression on 32-bit hosts [Re: [RFA][PATCH v5 2/2] S/390: Add TDB regset]


> PS:I think that system includes should be banned
> in all files that are used for cross-debugging.

This is already the main idea, except that we cannot banish
all system includes. For instance, includes that are part of
the C standard are OK (ctype.h, stdint.h, stdarg.h, etc) are
fine. Others, such as dlfcn.h or sys/cygwin.h, on the other
hand, are not.

> Especially cases like <string.h> should be avoided as we do have
> common/gdb_string.h...

Agreed on this one.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]