This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR server/15959


Thanks Yao.

On 09/17/2013 10:18 AM, Yao Qi wrote:

> +static void
> +marker (void)
> +{}
> +
> +int
> +main(void)

Missing space after parens (you added it in "marker").

> +{
> +  d = getenv("TEST");

Here too.

> +
> +  marker ();
> +
> +  return 0;
> +}

I think the test will fail on Windows, because there's no
"env" binary there.  I think we should first try to see
if running "env" works, with "remote_exec target", and
mark the test UNSUPPORTED if it doesn't.

Otherwise it looks good to me.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]