This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb/aarch64-linux-tdep.c: Call linux_init_abi.
- From: Will Newton <will dot newton at linaro dot org>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, Patch Tracking <patches at linaro dot org>
- Date: Thu, 10 Oct 2013 11:41:44 +0100
- Subject: Re: [PATCH] gdb/aarch64-linux-tdep.c: Call linux_init_abi.
- Authentication-results: sourceware.org; auth=none
- References: <524F1684 dot 8070804 at linaro dot org> <20131007050233 dot GB3092 at adacore dot com> <CANu=Dmj3vKXVTACXiouf1qzF9MosT8GbNfAhakUnoAXuq-H2EQ at mail dot gmail dot com>
On 7 October 2013 08:36, Will Newton <will.newton@linaro.org> wrote:
> On 7 October 2013 06:02, Joel Brobecker <brobecker@adacore.com> wrote:
>>> If we are running on a Linux platform we should call linux_init_abi
>>> in order to get all the useful hooks it enables.
>>>
>>> gdb/ChangeLog:
>>>
>>> 2013-10-04 Will Newton <will.newton@linaro.org>
>>>
>>> * aarch64-linux-tdep.c (aarch64_linux_init_abi): Call
>>> linux_init_abi.
>>
>> This makes sense to me, and it's actually what the 32bit side of
>> the code is already doing. OK to apply.
>
> I'll wait a couple of days to see if anyone from ARM objects.
>
>> It'd be nice also if you could confirm that this patch was tested
>> prior to submitting, and how it affects the testsuite results.
>> This often helps future research...
>
> The patch was tested manually to check that things like "info proc
> maps" now works. The testsuite is in pretty bad shape on aarch64 but
> no new failures are added.
I applied this as there were no objections.
--
Will Newton
Toolchain Working Group, Linaro