This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 07/13] fix up gdb.trace
- From: Tom Tromey <tromey at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 17 Oct 2013 12:56:29 -0600
- Subject: Re: [PATCH 07/13] fix up gdb.trace
- Authentication-results: sourceware.org; auth=none
- References: <1377290210-483-1-git-send-email-tromey at redhat dot com> <1377290210-483-8-git-send-email-tromey at redhat dot com> <521C9AF4 dot 4050704 at redhat dot com>
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> ... not this one. I'd move all defaults to this else
Pedro> block. Same in tfile.exp.
Done.
>> -# Make sure we are starting fresh.
>> -remote_file host delete tfile-basic.tf
>> -remote_file target delete tfile-basic.tf
>> +if {!$purely_local} {
>> + # Make sure we are starting fresh.
>> + remote_file host delete tfile-basic.tf
>> + remote_file target delete tfile-basic.tf
>> +}
Pedro> Shouldn't we delete the previous version of the file
Pedro> in local mode? tfile.exp does keep this unconditional.
Done.
>> -gdb_test "target tfile tfile-basic.tf" "Created tracepoint.*" \
>> +gdb_test "target tfile $tfile_basic" "Created tracepoint.*" \
>> "target tfile"
>>
>> gdb_test "info trace" ".*tracepoint.*in write_basic_trace_file.*" \
>> @@ -108,7 +125,7 @@ gdb_start
>>
>> gdb_load $binfile
>>
>> -gdb_test "target tfile tfile-error.tf" "Created tracepoint.*" \
>> +gdb_test "target tfile $tfile_error" "Created tracepoint.*" \
>> "target tfile"
Pedro> This seems to introduce duplicated messages in gdb.sum.
Fixed.
Pedro> (A good exercise would be to compare gdb.sum before/after whole series.)
Yeah, I did do that, and I believe my comparison script handles
duplicates properly. But I will redo it before resending the branch.
Tom