This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Extra error message from update_watchpoint


On 10/18/2013 10:20 AM, Andrew Burgess wrote:
> While working on this:
>   URL

:-)

> @@ -1946,8 +1946,13 @@ update_watchpoint (struct watchpoint *b, int reparse)
>  		}
>  	    }
>  	  else if (!b->base.ops->works_in_software_mode (&b->base))
> -	    error (_("Expression cannot be implemented with "
> -		     "read/access watchpoint."));
> +	    {
> +	      if (!can_use_hw_watchpoints)
> +		error (_("Software read/access watchpoints not supported."));

Hmm, is this really "not supported", or rather "explicitly disabled"?
I think I'd prefer:

		error (_("Hardware watchpoints support disabled.  "
			 "See set/show can-use-hw-watchpoints."));

which also hints towards the toggle.  WDYT?

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]