This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
> 2013/10/30 Tom Tromey <tromey@redhat.com> > > >>>>> ">" == hex <heixia108@gmail.com> writes: > > >> Thank you for the review. I have attached the test case. > > The test case needs a ChangeLog entry. > > I'd much prefer a test using the DWARF assembler than one using actual > assembly code. There are other examples in gdb.dwarf2. The reason to > prefer the DWARF assembler is that it is more portable. > > >> # You should have received a copy of the GNU General Public License > >> # along with this program. If not, see <http://www.gnu.org/licenses/>. > >> load_lib dwarf.exp > > A blank line between the comments and the first line of code, please. > > >> # Test DW_OP_stack_value and DW_OP_implicit_value. > > This comment seems incorrect. > > Tom Thank you for the comments. A new version of test file is attached. And the original patch is at https://sourceware.org/ml/gdb-patches/2013-10/msg00747.html. gdb/testsuite/Changelog: 2013-11-01 Jun Gong <heixia108@gmail.com> * gdb.dwarf2/const-var.exp: New file. Jun
Attachment:
const-var.exp
Description: Binary data
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |