This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Improve MI inferior output check / mi-console.exp
- From: Pedro Alves <palves at redhat dot com>
- To: lgustavo at codesourcery dot com
- Cc: "'gdb-patches at sourceware dot org'" <gdb-patches at sourceware dot org>, iain at codesourcery dot com
- Date: Tue, 05 Nov 2013 18:13:39 +0000
- Subject: Re: [PATCH] Improve MI inferior output check / mi-console.exp
- Authentication-results: sourceware.org; auth=none
- References: <526DC9BB dot 6060100 at codesourcery dot com> <526E7DF2 dot 4050509 at redhat dot com> <526ECC81 dot 3000300 at codesourcery dot com> <526F974C dot 9030404 at redhat dot com> <5270FBD1 dot 7040908 at codesourcery dot com> <5273992C dot 5040007 at redhat dot com> <5277256D dot 5000303 at codesourcery dot com>
On 11/04/2013 04:41 AM, Luis Machado wrote:
>> > I don't think it does completely yet? A check for the
>> > sim is missing. We'd need:
>> >
>> > [target_info protocol] == "sim"
>> >
>> > (see mi_gdb_target_load)
> Done.
...
> - -i $mi_inferior_spawn_id -re "$ipattern" {
> - pass "$message inferior output"
> + if { [target_info gdb_protocol] == "remote"
> + || [target_info gdb_protocol] == "extended-remote"
> + || [target_info gdb_protocol] == "sim"} {
That's not what I suggested, and I don't think it'd work
the same?
Looking around dejagnu, we see:
/usr/share/dejagnu/config/sim.exp:136:set_board_info protocol "sim"
And lots of boards load that config:
$ grep load_generic_config /usr/share/dejagnu/* -rn| grep sim
/usr/share/dejagnu/baseboards/m32r-linux-sim.exp:25:load_generic_config "sim"
/usr/share/dejagnu/baseboards/mips-sim.exp:22:load_generic_config "sim"
/usr/share/dejagnu/baseboards/mn10300-sim.exp:26:load_generic_config "sim"
/usr/share/dejagnu/baseboards/mips64-sim.exp:26:load_generic_config "sim"
...
But
$ grep gdb_protocol /usr/share/dejagnu/* -rn| grep sim
comes out empty.
Otherwise looks OK.
--
Pedro Alves