This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Move "types deeply equal" code from py-type.c to gdbtypes.c


Doug Evans <xdje42@gmail.com> writes:

> On Thu, Nov 14, 2013 at 9:24 AM, Doug Evans <xdje42@gmail.com> wrote:
>> On Sat, Nov 9, 2013 at 11:54 AM, Doug Evans <xdje42@gmail.com> wrote:
>>> Ok, no more attachment.
>>>
>>> 2013-11-09  Doug Evans  <xdje42@gmail.com>
>>>
>>>         * gdbtypes.c: #include bcache.h, dwarf2loc.h.
>>>         (type_equality_entry): Move here from python/py-type.c.
>>>         (type_equality_entry_d): Ditto.
>>>         (compare_maybe_null_strings, check_types_equal): Ditto.
>>>         (check_types_worklist, types_deeply_equal): Ditto.
>>>         * gdbtypes.h (types_deeply_equal): Declare.
>>>         * python/py-type.c: Remove inclusion of bcache.h, dwarf2loc.h.
>>>         (typy_richcompare): Update.
>>
>> Ping.
>
> Since this is just a simple cleanup, there's no real need to put
> someone to the trouble of doing a code review so I think I'm just
> going to check this in.
>
> Guess I should have just submitted it that way in the first place.
> Good thing to know for next time.

Committed.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]