This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] Events when inferior is modified
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: Nick Bull <nicholaspbull at gmail dot com>, gdb-patches at sourceware dot org
- Date: Mon, 25 Nov 2013 09:48:28 +0000
- Subject: Re: [PATCH v2] Events when inferior is modified
- Authentication-results: sourceware.org; auth=none
- References: <51CDBD48 dot 6010903 at gmail dot com> <87k3k7kbdy dot fsf at fleche dot redhat dot com> <CABbKtXsh+BG6=s6ZmaoEFYeiFR-9SAWqMYk3DqP-Ej047zd7LQ at mail dot gmail dot com> <528A0A83 dot 1080203 at gmail dot com>
On 18/11/13 12:39, Nick Bull wrote:
> This patch adds new observers, and corresponding Python events, for
> various actions on an inferior: calling a function (by hand),
> modifying registers or modifying memory.
Thanks just a few nits and some questions. I did not see tests for
these, and also, documentation? In any case, both are needed.
Cheers,
Phil
> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
> index 975edbf..7775bde 100644
> --- a/gdb/Makefile.in
> +++ b/gdb/Makefile.in
> @@ -297,6 +297,7 @@ SUBDIR_PYTHON_OBS = \
> py-function.o \
> py-gdb-readline.o \
> py-inferior.o \
> + py-infcallevent.o \
I'd appreciate if you kept the alphabetical ordering here.
> py-infthread.o \
> py-lazy-string.o \
> py-linetable.o \
> @@ -333,6 +334,7 @@ SUBDIR_PYTHON_SRCS = \
> python/py-function.c \
> python/py-gdb-readline.c \
> python/py-inferior.c \
> + python/py-infcallevent.c \
And here.
> +py-infcallevent.o: $(srcdir)/python/py-infcallevent.c
> + $(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/py-infcallevent.c
> + $(POSTCOMPILE)
> +
> py-infthread.o: $(srcdir)/python/py-infthread.c
> $(COMPILE) $(PYTHON_CFLAGS) $(srcdir)/python/py-infthread.c
> $(POSTCOMPILE)
Ditto.
> diff --git a/gdb/doc/observer.texi b/gdb/doc/observer.texi
> index f753965..ab15725 100644
> --- a/gdb/doc/observer.texi
> +++ b/gdb/doc/observer.texi
> @@ -253,6 +253,22 @@ The trace state variable @var{tsv} is deleted. If @var{tsv} is
> diff --git a/gdb/python/py-event.h b/gdb/python/py-event.h
> index f0ff629..2f2da90 100644
> --- a/gdb/python/py-event.h
> +++ b/gdb/python/py-event.h
> @@ -105,6 +105,15 @@ typedef struct
> extern int emit_continue_event (ptid_t ptid);
> extern int emit_exited_event (const LONGEST *exit_code, struct inferior *inf);
>
> +typedef enum
> +{
> + inferior_altered_pre_call,
> + inferior_altered_post_call,
> + inferior_altered_register_change,
> + inferior_altered_memory_change
> +} inferior_altered_kind;
> +
I'm kind of on the fence about the inferior_altered naming. A lot of
things can alter an inferior which would make this a very broad event
category. Like single stepping I would consider altering the inferior.
With your memory changed event, would it fire on a breakpoint
insertion? GDB does a lot of installing/uninstalling of breakpoints
behind the scene in the inferior.
Also, it would be super if we could split up the register
and memory events with read/write events. What do you think?
> diff --git a/gdb/python/py-infcallevent.c b/gdb/python/py-infcallevent.c
> new file mode 100644
> index 0000000..68e70f1
> --- /dev/null
> +++ b/gdb/python/py-infcallevent.c
> @@ -0,0 +1,98 @@
> +/* Python interface to inferior function events.
> +
> + Copyright (C) 2009-2013 Free Software Foundation, Inc.
> +
If this is a new file, probably just 2013.
> +/* Callback function which notifies observers when a continue event occurs.
> + This function will create a new Python continue event object.
> + Return -1 if emit fails. */
> +
This comment attached to the function below looks pasted from another function?
> +int
> +emit_inferior_altered_event (inferior_altered_kind flag)
> +{
> + PyObject *event;
> +
> + if (evregpy_no_listeners_p (gdb_py_events.inferior_altered))
> + return 0;
> +
> + event = create_inferior_call_event_object (flag);
> + if (event != NULL)
> + return evpy_emit_event (event, gdb_py_events.inferior_altered);
> + return -1;
> +}
> +
Cheers,
Phil