This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v1 1/1] Fix PR16193 - gdbserver aborts.
- From: Walfred Tedeschi <walfred dot tedeschi at intel dot com>
- To: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- Cc: palves at redhat dot com, yao at codesourcery dot com, gdb-patches at sourceware dot org
- Date: Mon, 25 Nov 2013 16:30:53 +0100
- Subject: Re: [PATCH v1 1/1] Fix PR16193 - gdbserver aborts.
- Authentication-results: sourceware.org; auth=none
- References: <1385386802-16948-1-git-send-email-walfred dot tedeschi at intel dot com> <201311251449 dot rAPEn6uZ014952 at glazunov dot sibelius dot xs4all dot nl> <AC542571535E904D8E8ADAE745D60B191B1DBFEC at IRSMSX104 dot ger dot corp dot intel dot com> <201311251518 dot rAPFIgbc010735 at glazunov dot sibelius dot xs4all dot nl>
Am 11/25/2013 4:18 PM, schrieb Mark Kettenis:
From: "Tedeschi, Walfred" <walfred.tedeschi@intel.com>
Date: Mon, 25 Nov 2013 14:56:59 +0000
Hello Mark,
Ok, I Will let it symmetrical to the AVX, i.e:
/* In case one of the MPX XCR0 bits is set we consider we have MPX.
#define HAS_MPX(XCR0) ((XCR0) & I386_XSTATE_MPX) == I386_XSTATE_MPX
Still doesn't do what it says on the tin. The macro is checking if
*both* bits are set. If you want to have the code match the comment
it needs to be changed to something like:
#define HAS_MPX(XRC0) (((XRC0) & I386_XSTATE_MPX) != 0)
or you need to change the comment to state that all bits need to be set.
Hello Mark,
What you proposed is better.
I will incorporate your feedback and Pedro's feedback and resend it.
Thanks your review and feedback!
Regards,
-Fred
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052