Re: [PATCH v1 03/13] script language API for GDB: python.[ch] changes

[Phil Muldoon <pmuldoon at redhat dot com>]

> +
> +extern int gdbpy_auto_load_enabled (const struct script_language_defn *);
> +
> +/* script_language_ops "methods".  */
> +
> +extern int gdbpy_apply_val_pretty_printer
> +  (const struct script_language_defn *,
> +   struct type *type, const gdb_byte *valaddr,
> +   int embedded_offset, CORE_ADDR address,
> +   struct ui_file *stream, int recurse,
> +   const struct value *val,
> +   const struct value_print_options *options,
> +   const struct language_defn *language);
> +extern enum script_bt_status gdbpy_apply_frame_filter
> +  (const struct script_language_defn *,
> +   struct frame_info *frame, int flags, enum script_frame_args args_type,
> +   struct ui_out *out, int frame_low, int frame_high);
> +extern void gdbpy_preserve_values (const struct script_language_defn *,
> +				   struct objfile *objfile,
> +				   htab_t copied_types);
> +extern enum scr_bp_stop gdbpy_breakpoint_cond_says_stop
> +  (const struct script_language_defn *, struct breakpoint *);
> +extern int gdbpy_breakpoint_has_cond (const struct script_language_defn *,
> +				      struct breakpoint *b);

I did not ask in the previous patch, but why could not these functions
have been kept in Python?

>  
> +/* Some code (e.g., MI) wants to know if a particular scripting language
> +   successfully initialized.
> +   Return non-zero if Python scripting successfully initialized.  */
> +
> +int
> +script_lang_python_initialized (void)
> +{
> +  if (script_language_python.ops != NULL)
> +    return script_language_python.ops->initialized (&script_language_python);
> +  return 0;
> +}
> +

I missed the convention here, but I thought that methods exported to
the ops struct had a gdbpy_ prefix?

Cheers,

Phil