This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 4/6] gdbserver: Delimit debugging output for readability
- From: Pedro Alves <palves at redhat dot com>
- To: Doug Evans <dje at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 18 Dec 2013 11:17:03 +0000
- Subject: Re: [PATCH 4/6] gdbserver: Delimit debugging output for readability
- Authentication-results: sourceware.org; auth=none
- References: <yjt2zjnztait dot fsf at ruffy dot mtv dot corp dot google dot com>
On 12/17/2013 09:47 PM, Doug Evans wrote:
> + We could also use indentation, but that's adds more complexity.
"but that adds"
Looks good to me, though I think it'd be better to write it as:
linux_wait_1 ()
...
/* Debugging output is delimited to make it easier to read. */
#define DELIMITER "====\n"
if (debug_threads)
fprintf (stderr, DELIMITER "linux_wait_1: [%s]\n", target_pid_to_str (ptid));
...
...
if (debug_threads)
fprintf (stderr, "linux_wait_1 ret = null_ptid\n" DELIMITER);
#undef DELIMITER
}
--
Pedro Alves